[Parse] Remove special handling for .<keyword><code-complete> #18869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
jrose-apple
approved these changes
Aug 21, 2018
rintaro
force-pushed
the
parse-dot-kw-complete
branch
from
a6bb4eb to
10e6ed7
Compare
|
Well... Added test cases 💦 |
At the time this logic was introduced in 8f83ca6, `<expr>.<keyword>` wasn't allowed. Now that SE-0071 has been implemented, this logic doesn't provide any positive effects.
rintaro
force-pushed
the
parse-dot-kw-complete
branch
from
10e6ed7 to
fdcdeeb
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time this logic was introduced in 8f83ca6,
<expr>.<keyword>wasn't allowed. Now that SE-0071 has been implemented, this logic doesn't provide any positive effects.