Skip to content

[nfc] Squash release build warnings #18986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

airspeedswift
Copy link
Member

In a couple of these I'm skipping creating the temporary variable and just putting the call in the assert, dunno if that's accepted style, seems cleaner than having to add another line.

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test

@jrose-apple
Copy link
Contributor

Putting the call in the assert is fine. I suspect the people who wrote these assertions tried to keep the entire thing on one line, but we have multi-line asserts elsewhere. What's not standard is your line wrapping. :-) We're not completely consistent about whether the && goes at the end of the previous line or the start of the subsequent line, but in the latter case the indentation aligns the && with the first line, not the right-side argument.

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2ea14cdf196e4f9dcb0734362da6a8c8ab404697

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2ea14cdf196e4f9dcb0734362da6a8c8ab404697

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ad1c9d29856493cfaba68411a83d7efd4dcb55b0

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ad1c9d29856493cfaba68411a83d7efd4dcb55b0

@airspeedswift
Copy link
Member Author

@jrose-apple this better?

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks.

@airspeedswift airspeedswift merged commit 6567438 into swiftlang:master Aug 28, 2018
@airspeedswift airspeedswift deleted the release-warnings branch August 28, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants