-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[nfc] Squash release build warnings #18986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nfc] Squash release build warnings #18986
Conversation
@swift-ci please smoke test |
Putting the call in the assert is fine. I suspect the people who wrote these assertions tried to keep the entire thing on one line, but we have multi-line asserts elsewhere. What's not standard is your line wrapping. :-) We're not completely consistent about whether the |
2ea14cd
to
ad1c9d2
Compare
@swift-ci please test |
Build failed |
ad1c9d2
to
479dd23
Compare
Build failed |
@swift-ci please test |
Build failed |
Build failed |
@jrose-apple this better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks.
In a couple of these I'm skipping creating the temporary variable and just putting the call in the assert, dunno if that's accepted style, seems cleaner than having to add another line.