Fix critical edges #19020
Merged
Fix critical edges #19020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow passes that optimize phis to be run in the mandatory pipeline. It also simplifies SIL invariants and will unblock much needed simplification of BlockArgument handling.
|
@swift-ci test. |
|
@swift-ci test source compatibility. |
|
Build failed |
|
@swift-ci smoke test linux. |
1 similar comment
|
@swift-ci smoke test linux. |
|
@atrick So this bans non cond br critical edges in raw sil? |
|
@gottesmm Yes, this gives raw and canonical SIL the same invariants, so that all our passes and utilities are just correct by definition. It's also one important piece in simplifying the SILBlockArgument APIs in general. This PR originally fixed SILGen to emit the default switch block, but that's irrelevant after @rjmccall 's commit yesterday that defined away the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle critical edges consistently in all SIL stages.
This will allow passes that optimize phis to be run in the mandatory
pipeline. It also simplifies SIL invariants and will unblock
much needed simplification of BlockArgument handling.