Basic: correct use-after-move on Windows #19099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of evaluation for arguments is underspecified in the language specification. It is permissible to evluate right to left, resulting in the use after the move of the OwnedPtr. This happens in practice on Windows. Alter the construction to avoid this.
|
@swift-ci please test |
jrose-apple
approved these changes
Sep 1, 2018
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of evaluation for arguments is underspecified in the language
specification. It is permissible to evluate right to left, resulting in the use
after the move of the OwnedPtr. This happens in practice on Windows. Alter the
construction to avoid this.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.