Skip to content

build: use the exported config for libdispatch #19834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2018
Merged

build: use the exported config for libdispatch #19834

merged 1 commit into from
Oct 18, 2018

Conversation

compnerd
Copy link
Member

Pass along the configuration through the exported target for the standard
library. Still pass the compiler by hand to allow building libdispatch against
just a build of the standard library.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
build: use the exported config for libdispatch
b99a0f4 
Pass along the configuration through the exported target for the standard
library.  Still pass the compiler by hand to allow building libdispatch against
just a build of the standard library.
@compnerd
Copy link
Member Author

Please test with the following PRs:
swiftlang/swift-corelibs-libdispatch#397

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b99a0f4

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b99a0f4

@compnerd
Copy link
Member Author

Please test with the following PRs:
swiftlang/swift-corelibs-libdispatch#397

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b99a0f4

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b99a0f4

@compnerd
Copy link
Member Author

Please test with the following PRs:
swiftlang/swift-corelibs-libdispatch#397

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b99a0f4

@compnerd
Copy link
Member Author

Please test with the following PRs:
swiftlang/swift-corelibs-libdispatch#397

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b99a0f4

@compnerd
Copy link
Member Author

Please test with the following PRs:
swiftlang/swift-corelibs-libdispatch#397

@swift-ci please test

This was referenced Oct 12, 2018
Merged
Closed
@gottesmm gottesmm self-requested a review October 12, 2018 19:09
gottesmm
gottesmm approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@compnerd compnerd merged commit 6360bcc into swiftlang:master Oct 18, 2018
@compnerd compnerd deleted the exports branch October 18, 2018 16:40
@Rostepher
Copy link
Contributor

I think we need to cherry-pick this to the 5.0 branch. The Linux bots are broken because libdispatch is trying to run find_package(Swift).

@Rostepher Rostepher mentioned this pull request Oct 24, 2018
Merged
shahmishal added a commit that referenced this pull request Oct 25, 2018
@shahmishal
Merge pull request #20023 from Rostepher/cherry-pick-pr-19834-to-5.0
c052770 
[Build System: build-script-impl] Cherry-pick #19834 to the 5.0 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm gottesmm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compnerd @swift-ci @Rostepher @gottesmm