Skip to content

ClangImporter: Update Swift for changes in clang (PCH + Modules issues) #20238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2018
Merged

ClangImporter: Update Swift for changes in clang (PCH + Modules issues) #20238

merged 1 commit into from
Nov 12, 2018

Conversation

bcardosolopes
Copy link
Contributor

This sets the NeededByPCHOrCompilationUsesPCH language option when
emitting a brigding PCH.

rdar://problem/35056912
rdar://problem/30384801

Initial patch by Adrian Prantl

(cherry picked from commit 5d5f542)
(cherry picked from commit fa2a577)

@bcardosolopes
Copy link
Contributor Author

Please test with following pull request:
apple/swift-clang#221

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 2, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8160aa832dc83d3a41c0d94e3d1e047067d95869

@swift-ci
Copy link
Contributor

swift-ci commented Nov 2, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8160aa832dc83d3a41c0d94e3d1e047067d95869

@bcardosolopes
Copy link
Contributor Author

Please test with following pull request:
apple/swift-clang#221

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 2, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8160aa832dc83d3a41c0d94e3d1e047067d95869

This sets the NeededByPCHOrCompilationUsesPCH language option when
emitting a brigding PCH.

rdar://problem/35056912
rdar://problem/30384801

Initial patch by Adrian Prantl

(cherry picked from commit 5d5f542)
(cherry picked from commit fa2a577)
@bcardosolopes
Copy link
Contributor Author

Please test with following pull request:
apple/swift-clang#221

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8160aa832dc83d3a41c0d94e3d1e047067d95869

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2018

Build failed
Swift Test Linux Platform
Git Sha - bf5073f

@bcardosolopes bcardosolopes merged commit a950321 into swiftlang:swift-5.0-branch Nov 12, 2018
@jrose-apple
Copy link
Contributor

This needs to go to master too. (It should have gone to master first, really.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants