Skip to content

build: do not create WinSDK symlinks when unneeded #20340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 6, 2018

When building on case insensitive filesystems, there is no need to
create the library symlink forest as the paths will be resolved properly
due to the insensitivity. This avoids a bit of work and spew on
Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

When building on case insensitive filesystems, there is no need to
create the library symlink forest as the paths will be resolved properly
due to the insensitivity.  This avoids a bit of work and spew on
Windows.
@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 6, 2018

Build failed
Swift Test Linux Platform
Git Sha - a5d360b

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2018

@swift-ci please test Linux platform

@compnerd compnerd merged commit d082e15 into swiftlang:master Nov 6, 2018
@compnerd compnerd deleted the symlinks branch November 6, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants