-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[CMake] Remove swift-syntax install component #20554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00898a7
to
6a3246f
Compare
@swift-ci please test |
@swift-ci build toolchain |
171c3c4
to
8d44843
Compare
Linux Toolchain (Ubuntu 16.04) Install command |
Build failed |
Build failed |
utils/build-presets.ini
Outdated
@@ -1070,7 +1070,7 @@ test-installable-package | |||
# If someone uses this for incremental builds, force reconfiguration. | |||
reconfigure | |||
|
|||
swift-install-components=compiler;clang-builtin-headers;stdlib;swift-syntax;sdk-overlay;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers | |||
swift-install-components=compiler;clang-builtin-headers;stdlib;syntax;sdk-overlay;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to delete the whole component, rather than leaving syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
8d44843
to
0a861af
Compare
@swift-ci please test |
Build failed |
Build failed |
single quotes in branch names? madness |
Toolchain builds finished, not sure why Github hasn't realized it yet. You should be good to merge this @harlanhaskins. 👍 |
@kastiglione You'd be surprised what git allows for branch names |
@harlanhaskins I'm not surprised git allowed it, surprised anyone would do that |
This is now unused.