Skip to content

[CMake] Remove swift-syntax install component #20554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

harlanhaskins
Copy link
Contributor

This is now unused.

@harlanhaskins
Copy link
Contributor Author

@swift-ci please test

@shahmishal
Copy link
Member

@swift-ci build toolchain

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 171c3c49898d658d92e1f3213dfcb8ae77190c31

Install command
tar zxf swift-PR-20554-92-ubuntu16.04.tar.gz
More info

@harlanhaskins
Copy link
Contributor Author

@swift-ci please build toolchain
@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 171c3c49898d658d92e1f3213dfcb8ae77190c31

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 171c3c49898d658d92e1f3213dfcb8ae77190c31

@@ -1070,7 +1070,7 @@ test-installable-package
# If someone uses this for incremental builds, force reconfiguration.
reconfigure

swift-install-components=compiler;clang-builtin-headers;stdlib;swift-syntax;sdk-overlay;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers
swift-install-components=compiler;clang-builtin-headers;stdlib;syntax;sdk-overlay;license;sourcekit-xpc-service;swift-remote-mirror;swift-remote-mirror-headers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to delete the whole component, rather than leaving syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@harlanhaskins
Copy link
Contributor Author

@swift-ci please test
@swift-ci please build toolchain

@Rostepher
Copy link
Contributor

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8d44843043991ea9eab60c57f562190a8d2bccc8

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8d44843043991ea9eab60c57f562190a8d2bccc8

@kastiglione
Copy link
Contributor

single quotes in branch names? madness

@Rostepher
Copy link
Contributor

Rostepher commented Nov 14, 2018

Toolchain builds finished, not sure why Github hasn't realized it yet. You should be good to merge this @harlanhaskins. 👍

@harlanhaskins
Copy link
Contributor Author

@kastiglione You'd be surprised what git allows for branch names

@harlanhaskins harlanhaskins merged commit b707b89 into swiftlang:master Nov 14, 2018
@kastiglione
Copy link
Contributor

@harlanhaskins I'm not surprised git allowed it, surprised anyone would do that :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants