IRGen: Force emission of lazy witness table when conformance descriptor is referenced [5.0] #20761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or is referenced Otherwise with the new resilient witness table emission pattern, we might miss conformances for refined protocols, since the witness table itself is never referenced, only the conformance descriptor is. Fixes <rdar://problem/46133018>.
slavapestov
changed the title
|
@swift-ci Please test |
|
As per Slava, @DougGregor has already reviewed this. |
|
@AnnaZaks I think you actually have to click the 'review' button and approve it |
AnnaZaks
approved these changes
Nov 26, 2018
|
Thanks! Looks like you'll have to actually merge it too, it still says "Merging blocked". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise with the new resilient witness table emission pattern, we might miss
conformances for refined protocols, since the witness table itself is never
referenced, only the conformance descriptor is.
Fixes rdar://problem/46133018.