Re-enable a test that had been disabled at one point. #20778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw a failure of this test on Linux at some point, and disabled it. It looks like it may have been due to the fact that the `%target-typecheck-verify-swift` provides the filename, but we explicitly provide the filename in the test invocation here as well. I'm going to re-enable and see if we can get through tests on all supported platforms.
|
@swift-ci Please smoke test |
|
You should remove the file name then! |
|
@jrose-apple Yes, I'm planning on it and won't merge this until that time. I wanted to see if we somehow had some unusual difference in behavior between the platforms first. It's possible this had also started failing on macOS but it wasn't noticed by the time the test was disabled. |
|
Passes with test re-enabled. Will push a change to remove the duplicated filename, retest and merge. |
It's implied by `%target-typecheck-verify-swift`.
|
@swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw a failure of this test on Linux at some point, and disabled
it. It looks like it may have been due to the fact that the
%target-typecheck-verify-swiftprovides the filename, but weexplicitly provide the filename in the test invocation here as well.
I'm going to re-enable and see if we can get through tests on all
supported platforms.
Fixes: rdar://problem/44305428