Accessor synthesis cleanup (NFC) #21117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
…rs with synthesized bodies
Also change some TypeChecker usages to ASTContext.
…ture computation If we computed captures before completing a lazy getter body, we would fail to consider the 'self' capture properly. Instead make it resilient to such ordering issues by checking in capture computation if the lazy property has a getter yet or not.
slavapestov
force-pushed
the
accessor-synthesis-cleanup
branch
from
eb7adbf to
a76012d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two mechanisms for lazily synthesizing a function body. Now there is only one. I'm going to use this in the ClangImporter for a few things later.