Skip to content

[5.0] IRGen: Fix building a closure that captures a struct containing… #21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

… a reference using an indirect convention

A <{ %AClass*}> value cannot be bitcasted to a swift.refcounted*.

  • No ABI impact
  • Fixes a compiler crash

rdar://46538967

… a reference using an indirect convention

A <{ %AClass*}> value cannot be bitcasted to a swift.refcounted*.

rdar://46538967
@aschwaighofer aschwaighofer requested a review from a team as a code owner December 10, 2018 23:00
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - cfda992

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - cfda992

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aschwaighofer
Copy link
Contributor Author

@eeckstein The tests have passed. Can you merge this PR?

@eeckstein eeckstein merged commit 7ad4ce8 into swiftlang:swift-5.0-branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants