[5.0] [Key paths] Map Hashable conformances for subscript indexes out of context #21267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…ntext. When SILGen maps the subscript indices used in a keypath out of context, also map the conformance to Hashable. Fixes rdar://problem/46632723. (cherry picked from commit 0a2e726)
DougGregor
force-pushed
the
keypath-hashable-subscript-indices-5.0
branch
from
f8b1b8f to
45f6014
Compare
|
@swift-ci please test |
|
Build failed |
AnnaZaks
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILGen et al where expecting interface types, so make sure that's how we
record them. Fixes rdar://problem/46632723.