Skip to content

[stdlib] tee _stdlib_AtomicInt > SwiftPrivate #21337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Dec 15, 2018

Turns out some people used this type despite it being prefixed with
_stdlib_, so we have to keep it, with an obsoletion message this time.
Second copy of the same type is kept available past Swift 5 in
SwiftPrivate for use in tests.

@moiseev moiseev force-pushed the atomic-int-reshuffle branch from a67e083 to ed841bb Compare December 15, 2018 00:16
@moiseev
Copy link
Contributor Author

moiseev commented Dec 15, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a67e083eed69e8f5985f7f7e5bbaf4b30c05f88a

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a67e083eed69e8f5985f7f7e5bbaf4b30c05f88a

@moiseev
Copy link
Contributor Author

moiseev commented Dec 18, 2018

@swift-ci Please smoke test Linux platform

Turns out some people used this type despite it being prefixed with
`_stdlib_`, so we have to keep it, with an obsoletion message this time.
Second copy of the same type is kept available past Swift 5 in
SwiftPrivate for use in tests.
@moiseev moiseev force-pushed the atomic-int-reshuffle branch from ed841bb to 1f5c0f8 Compare December 19, 2018 00:34
@moiseev
Copy link
Contributor Author

moiseev commented Dec 19, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ed841bb11358d0b1f95e60cfb02a13832cd908fb

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ed841bb11358d0b1f95e60cfb02a13832cd908fb

@moiseev moiseev merged commit ab87c70 into swiftlang:master Dec 19, 2018
@moiseev moiseev deleted the atomic-int-reshuffle branch December 19, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants