[SIMD] Add CustomDebugStringConvertible conformance for SIMD types. #21339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old SIMD types had a conformance to CustomDebugStringConvertible, but the new ones do not, causing a source compatibility regression. Add back a CustomDebugStringConvertible conformance. Fixes rdar://problem/46746829.
|
@swift-ci please smoke test |
xwu
reviewed
Dec 15, 2018
| @@ -109,6 +109,14 @@ public extension SIMD${n} where Scalar : FixedWidthInteger { | |||
| } | |||
| } | |||
|
|
|||
| extension SIMD${n} : CustomDebugStringConvertible { | |||
| /// Debug string representation | |||
There was a problem hiding this comment.
This overrides the default documentation for debugDescription. Was that intentional?
There was a problem hiding this comment.
I doubt it, but we can clean it up in another PR. =)
There was a problem hiding this comment.
I pulled the fix into #21379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old SIMD types had a conformance to CustomDebugStringConvertible,
but the new ones do not, causing a source compatibility
regression. Add back a CustomDebugStringConvertible conformance.
Fixes rdar://problem/46746829.