[TBDGen] Allow #warning/#error in protocols #21393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
reviewed
Dec 18, 2018
harlanhaskins
force-pushed
the
oops-indeed
branch
from
8c8f13f to
02911bc
Compare
|
@swift-ci please smoke test |
jrose-apple
reviewed
Dec 18, 2018
added 2 commits
December 17, 2018 18:05
Resolves [SR-9519](https://bugs.swift.org/browse/SR-9519)
It should support multi-line strings and strings with custom delimiters, as long as they’re not interpolating.
harlanhaskins
force-pushed
the
oops-indeed
branch
from
02911bc to
c9980f1
Compare
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Dec 18, 2018
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-9519
Also adds a few missing test cases for #warning.