[benchmark] Really Fix: random fail Benchmark_O.test.md #21507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the two measured samples from `Ackermann` happen to have the exact same value, the delta compression omits the number. Accept both forms. https://bugs.swift.org/browse/SR-9544
palimondo
changed the title
|
@eeckstein Please review. I should run the full test here, per our discussion in #21477 (comment), right? |
eeckstein
approved these changes
Dec 21, 2018
|
yes, please run the full test |
|
@swift-ci please test |
|
@eeckstein Can you please merge this before the holiday branch freeze? I might go to 😴 soon... |
|
Ups. It looks like the merging is blocked already... |
|
@shahmishal Once the test passes, can you please get somebody with authorization to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first attempt at fixing this didn't work out… #21459 (comment). This fixes it for real 🤞
When the two measured samples from
Ackermannhappen to have the exact same value, the delta compression omits the number. Accept both forms.https://bugs.swift.org/browse/SR-9544