Skip to content

Eliminate non-generic dependent types in ASD::getValueInterfaceType() #21518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Eliminate non-generic dependent types in ASD::getValueInterfaceType() #21518

wants to merge 1 commit into from

Conversation

rjmccall
Copy link
Contributor

This feels like a hack.

rdar://44762116

@rjmccall
Copy link
Contributor Author

@swift-ci Please test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4a219db

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4a219db

@slavapestov
Copy link
Contributor

Here is a better fix: #21519

@rjmccall
Copy link
Contributor Author

rjmccall commented Jan 2, 2019

Agreed that your fix is better.

@rjmccall rjmccall closed this Jan 2, 2019
@rjmccall rjmccall deleted the non-generic-subscript-with-dependent-element-type branch January 2, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjmccall @swift-ci @slavapestov