Skip to content

[benchmark] Add autoreleasepools to the Codable tests to prevent "lea… #21905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

…ks".

This was caught by the runtime leak checker.

rdar://47241432

…ks".

This was caught by the runtime leak checker.

rdar://47241432
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke benchmark

@swift-ci
Copy link
Contributor

Build comment file:

Code size: -O

TEST OLD NEW DELTA RATIO
Regression
Codable.o 27189 28401 +4.5% 0.96x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Improvement
DataAppendDataLargeToLarge 51200 37000 -27.7% 1.38x (?)

Code size: -Osize

TEST OLD NEW DELTA RATIO
Regression
Codable.o 27181 28577 +5.1% 0.95x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
DataAppendArray 4900 5600 +14.3% 0.88x (?)
CharacterPropertiesFetch 5810 6550 +12.7% 0.89x (?)
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB
--------------

@gottesmm
Copy link
Contributor Author

Merging to unblock CI.

@gottesmm gottesmm merged commit b34f9f8 into swiftlang:master Jan 16, 2019
@gottesmm gottesmm deleted the pr-e4aa69192289f84c89c0ffdec8febf6e15f0558f branch January 16, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants