[Sema] Fix derived property setter logic. #21995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derived property setters should inherit their parent's generic environment. This logic already existed in `declareDerivedPropertyGetter` but wasn't copied to `declareDerivedPropertySetter` for some reason. Add test using a derived `Differentiable.allDifferentiableVariables` setter in a generic nominal type.
|
Note that |
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived property setters should inherit their parent's generic environment.
This logic already existed in
declareDerivedPropertyGetterbut wasn't copiedto
declareDerivedPropertySetterfor some reason.Add test using a derived
Differentiable.allDifferentiableVariablessetter ina generic nominal type.