[5.0] Improve RemoteAST support for private types in LLDB #22136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When -enable-anonymous-context-mangled-names is provided, emit mangled names as part of the metadata of an anonymous context. This will allow us to match textual mangled names to the metadata. This is a backward-compatible ABI extension. Part of rdar://problem/38231646/. (cherry picked from commit 0c88b88)
Including the mangled names in anonymous context metadata can bloat code size, and is not needed for normal runtime resolution. However, it aids debugging, so have -g implies the emission of this extra metadata, which is always optional. (cherry picked from commit 580c992)
…te types. When an anonymous context descriptor provides a mangled name, use that mangled name to provide the private declaration name for its child context. This allows us to resolve private type names correctly when the corresponding anonymous context has its mangled name. Fixes rdar://problem/38231646. (cherry picked from commit 61d14ed)
|
@swift-ci please test |
AnnaZaks
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under
-g, start emitting mangled names into anonymous context descriptors.When an anonymous context descriptor provides a mangled name, use that
mangled name to provide the private declaration name for its child context.
This allows us to resolve private type names correctly when the corresponding
anonymous context has its mangled name.
Fixes rdar://problem/38231646.