Take 2 of “[SDK] Fix multiple issues with Swift KVO” #22311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reproposes @lilyball’s fixes in swiftlang#20103 while adding her fix to ensure observations are removed before observed objects in 32-bit testing.
|
@swift-ci please test |
lilyball
reviewed
Feb 1, 2019
| print("keyPathsAffectingValue: key == \\.name:", key == \Target2.name) | ||
| withExtendedLifetime(Dummy()) { (dummy) in | ||
| _ = dummy.observe(\.name) { (_, _) in } | ||
| } |
There was a problem hiding this comment.
These 2 lines have hard tabs instead of spaces.
| print("automaticallyNotifiesObservers: key == \\.name:", key == \Target2.name) | ||
| withExtendedLifetime(Dummy()) { (dummy) in | ||
| _ = dummy.observe(\.name) { (_, _) in } | ||
| } |
There was a problem hiding this comment.
These 2 lines have hard tabs instead of spaces.
There was a problem hiding this comment.
… one day, humanity will solve the problem of varying configurations between hosts and contexts
There was a problem hiding this comment.
(I will wait for testing to end before adding a fix.)
|
(It takes forever, but I want to make sure no platform is broken.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproposes @lilyball’s fixes in #20103 while adding her fix to ensure observations are removed before observed objects in 32-bit testing.