@objc extension makes even 'private' members '@objc'
#22436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
rjmccall
reviewed
Feb 7, 2019
lib/Sema/TypeCheckDeclObjC.cpp
Outdated
| return ObjCReason(ObjCReason::MemberOfObjCExtension); | ||
| if (isMemberOfObjCMembersClass(VD) && canInferImplicitObjC()) | ||
| if (isMemberOfObjCMembersClass(VD) && canInferImplicitObjC(false)) |
There was a problem hiding this comment.
I think these would both benefit from /*what this means*/ comments.
rjmccall
reviewed
Feb 7, 2019
lib/Sema/TypeCheckDeclObjC.cpp
Outdated
| @@ -1177,7 +1177,7 @@ Optional<ObjCReason> shouldMarkAsObjC(const ValueDecl *VD, bool allowImplicit) { | |||
| // (and extensions thereof) whose class hierarchies originate in Objective-C, | |||
| // e.g., which derive from NSObject, so long as the members have internal | |||
| // access or greater. | |||
| if (!canInferImplicitObjC()) | |||
| if (!canInferImplicitObjC(false)) | |||
DougGregor
approved these changes
Feb 7, 2019
This regressed in a8fb416, when we started using a helper function in more places. rdar://problem/47869562
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in #21657, when we started using a helper function in more places.
rdar://problem/47869562