Skip to content

[utils] Remove unused CMake var from LLDB build #22576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

bulbazord
Copy link
Contributor

This variable isn't used at all in LLDB's CMake build. It does appear in LLDB's XCode build for testing, so we can't remove it there.

cc @adrian-prantl @compnerd

@compnerd
Copy link
Member

Might be nice to keep it in sync, but reducing the number of variables we are passing around is certainly desirable

@compnerd
Copy link
Member

@swift-ci please smoke test

Copy link
Member

@weliveindetail weliveindetail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's fine. (Same for LLDB_PATH_TO_CLANG_SOURCE and probably possible also for Swift, since we use find_package there too.)

@bulbazord
Copy link
Contributor Author

Yes that's fine. (Same for LLDB_PATH_TO_CLANG_SOURCE and probably possible also for Swift, since we use find_package there too.)

Ooh, definitelyLLDB_PATH_TO_CLANG_SOURCE can be removed. Looks like there's one reference to it in the CMake but we don't do anything with it.. It does look like we do use LLDB_PATH_TO_SWIFT_SOURCE but that can probably be removed with a bit of work. I'll go ahead and remove the Clang one here. :)

@bulbazord bulbazord force-pushed the remove_unused_option branch from a5c9f1d to 8899fb5 Compare February 13, 2019 19:05
@compnerd
Copy link
Member

@swift-ci please smoke test and merge

@compnerd compnerd merged commit 14a6748 into swiftlang:master Feb 13, 2019
@bulbazord bulbazord deleted the remove_unused_option branch February 13, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants