Skip to content

[CMake] Fix dependencies found using LLVM's -DBUILD_SHARED_LIBS=TRUE #22651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2019
Merged

[CMake] Fix dependencies found using LLVM's -DBUILD_SHARED_LIBS=TRUE #22651

merged 1 commit into from
Feb 16, 2019

Conversation

davezarzycki
Copy link
Contributor

No description provided.

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

compnerd
compnerd approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, I don't expect that it should cause any problems on any of the targets.

@davezarzycki davezarzycki merged commit 0fe7e14 into swiftlang:master Feb 16, 2019
@davezarzycki davezarzycki deleted the fix_BUILD_SHARED_LIBS_bugs branch February 16, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@rjmccall rjmccall Awaiting requested review from rjmccall

@huonw huonw Awaiting requested review from huonw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davezarzycki @compnerd