Skip to content

[CSFix] Use fully qualified locators for requirement failures #22693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Feb 18, 2019

Would help to diagnose failures where requirement comes from
contextual type, also simplifies logic around requirement fixes
to some degree.

Would help to diagnose failures where requirement comes from
contextual type, also simplifies logic around requirement fixes
to some degree.
@xedin
Copy link
Contributor Author

xedin commented Feb 18, 2019

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Feb 18, 2019

@shahmishal Do you know if this Linux failure is already tracked?

15:04:04 SIL verification failed: nothrow flag used for callee without error result: calleeConv.funcTy->hasErrorResult()
15:04:04 Verifying instruction:
15:04:04      %245 = apply %10(%242, %244) : $@convention(method) (@owned String, @owned Scanner) -> @owned Scanner // users: %259, %361, %367, %253, %258, %366, %246
15:04:04      // function_ref closure #6 in TestScanner.testScanFloatingPoint()
15:04:04   %256 = function_ref @$s14TestFoundation0A7ScannerC21testScanFloatingPointyyFy0B00C0CcfU4_ : $@convention(thin) (@guaranteed Scanner) -> () // user: %258
15:04:04 ->   %258 = apply [nothrow] %256(%245) : $@convention(thin) (@guaranteed Scanner) -> ()
15:04:04 In function:
15:04:04 // TestScanner.testScanFloatingPoint()

@shahmishal
Copy link
Member

@xedin This issue has been resolved now.

@shahmishal
Copy link
Member

@swift-ci smoke test Linux

@xedin xedin merged commit ad802c3 into swiftlang:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants