Skip to content

[CodeCompletion] Analyze the parent of initializer #22717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 19, 2019

For Initializer decl context, type context analyzer should look into its parent context because that might constrain initializer's type.

rdar://problem/48208253

@rintaro
Copy link
Member Author

rintaro commented Feb 19, 2019

@swift-ci Please smoke test

@rintaro rintaro requested a review from benlangmuir February 19, 2019 19:54
@rintaro
Copy link
Member Author

rintaro commented Feb 19, 2019

@swift-ci Please smoke test OS X platform

For `Initializer` decl context, type context analyzer should look into
its parent context because that might constrain initializer's type.

rdar://problem/48208253
@rintaro rintaro force-pushed the ide-completion-declmemberinit-rdar48208253 branch from 628acee to fd9b6a1 Compare February 19, 2019 22:22
@rintaro
Copy link
Member Author

rintaro commented Feb 19, 2019

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Feb 20, 2019

@swift-ci Please smoke test OS X platform

@rintaro rintaro merged commit 69ff99f into swiftlang:master Feb 20, 2019
@rintaro rintaro deleted the ide-completion-declmemberinit-rdar48208253 branch February 20, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants