Skip to content

[Gardening] Remove DoubleWidth related dead code #23024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

palimondo
Copy link
Contributor

Remove auxiliary benchmark and tests for DoubleWidth which was removed from stdlib and stashed into prototype in #15470. These scattered remains were just a dead code. I'm leaving a comment breadcrumb in test/Prototypes/DoubleWidth.swift.gyb pointing here, to assist in easy resurrection (revert these commits).

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please test

@palimondo palimondo requested a review from eeckstein March 1, 2019 19:54
@palimondo
Copy link
Contributor Author

@eeckstein I'd like to remove the DoubleWidthDivision benchmark that always returns zero because the tested type was removed from stdlib. Please review 🙏

@swift-ci
Copy link
Contributor

swift-ci commented Mar 1, 2019

Performance: -O

TEST OLD NEW DELTA RATIO
Improvement
UTF8Decode_InitDecoding 228 200 -12.3% 1.14x (?)
UTF8Decode_InitFromBytes_ascii 311 289 -7.1% 1.08x (?)
Removed
DoubleWidthDivision 0 0 0

Performance: -Osize

TEST MIN MAX MEAN MAX_RSS
Removed
DoubleWidthDivision 0 0 0

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
String.data.Empty 91 98 +7.7% 0.93x (?)
Improvement
UTF8Decode_InitDecoding_ascii 428 393 -8.2% 1.09x (?)
Removed
DoubleWidthDivision 0 0 0
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@palimondo palimondo merged commit cbef630 into swiftlang:master Mar 2, 2019
@palimondo palimondo deleted the against-the-dark branch May 6, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants