Parser: properly handle token receiver in back tracking scopes #23172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X Platform |
nkcsgexi
force-pushed
the
token-receiver-back
branch
from
55a3b56 to
139d898
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please clean test Linux platform |
|
Build failed |
rintaro
approved these changes
Mar 8, 2019
|
But what was the difference between "on the line" or not? |
|
We only enter this back track scope when they are on the same line: https://github.com/apple/swift/blob/master/lib/Parse/ParseExpr.cpp#L1056. |
|
@swift-ci please smoke test on Linux Platform |
1 similar comment
|
@swift-ci please smoke test on Linux Platform |
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back tracking scope may lead to a same token to be consumed/received twice.
This patch introduces a DelayedTokenReceiver to temporarily store received
tokens during a back tracking scope. After the scope ends, the stored tokens
will be either transferred to the original token receiver in the parser or
be discarded, depending on whether the scope will actually back-track.
Fixing: rdar://42547871