[Typechecker] Allow static functions to overload enum cases #23227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e() to compute the type for the enum element decl, etc
slavapestov
reviewed
Mar 13, 2019
|
I have added some more tests to ensure non-functions can't redeclare an enum element (or vice versa). We only had one test for this, but I have added some more test cases to ensure we don't regress. |
|
@slavapestov Do you have any additional feedback or is this good to go? |
slavapestov
approved these changes
Mar 19, 2019
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
theblixguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with redeclaration checking where a static function would incorrectly get marked as a redeclaration of an enum element declaration, even if their types were different. See https://twitter.com/an0/status/1105187953834369025
Resolves SR-10084.