Test that initializers inherit '@objc' from convenience inits #23305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
This is weird behavior---there's no 'override' keyword here or anything! But we rely on it when a convenience initializer written in Objective-C dispatches to another convenience initializer. Changing this /will/ break some Apple Objective-C classes that are meant to be subclassed, unfortunately.
jrose-apple
force-pushed
the
convenient-like-clippy
branch
from
d2c82d0 to
9d3f643
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
slavapestov
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is weird behavior—there's no
overridekeyword here or anything! But we rely on it when a convenience initializer written in Objective-C dispatches to another convenience initializer. Changing this will break some Apple Objective-C classes that are meant to be subclassed, unfortunately.