Skip to content

[CodeCompletion] Look through implicit exprs to find the parsed expr #23498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 22, 2019

The parsed expression may be wrapped with various implicit expressions.
For example, if the expression is only element in array literal, it's wrapped with (arrayLiteral: <expr>).

@rintaro
Copy link
Member Author

rintaro commented Mar 22, 2019

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Mar 22, 2019

cc: @benlangmuir

@rintaro rintaro force-pushed the ide-completion-findparsed-ignoreimplicit branch from ece38f8 to f457a7c Compare March 22, 2019 20:47
@rintaro
Copy link
Member Author

rintaro commented Mar 22, 2019

@swift-ci Please smoke test

The parsed expression may be wrapped with various implicit expressions.
For example, if the expression is only element in array literal, it's
wrapped with `(arrayLiteral: <expr>)`.
@rintaro rintaro force-pushed the ide-completion-findparsed-ignoreimplicit branch from f457a7c to bfaa6af Compare March 22, 2019 22:01
@rintaro
Copy link
Member Author

rintaro commented Mar 22, 2019

@swift-ci Please smoke test

@rintaro rintaro merged commit 821d45b into swiftlang:master Mar 23, 2019
@rintaro rintaro deleted the ide-completion-findparsed-ignoreimplicit branch March 26, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants