Skip to content

[build-script] Add --time-test to build-script invocation for lldb te… #23781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2019
Merged

[build-script] Add --time-test to build-script invocation for lldb te… #23781

merged 2 commits into from
Apr 6, 2019

Conversation

dcci
Copy link
Member

@dcci dcci commented Apr 3, 2019

…sts.

rdar://problem/48986159

@dcci dcci requested review from adrian-prantl and shahmishal April 3, 2019 23:17
@dcci
Copy link
Member Author

dcci commented Apr 3, 2019

@swift-ci test

adrian-prantl
adrian-prantl requested changes Apr 3, 2019
View reviewed changes
utils/build-script-impl Outdated
@@ -3122,7 +3122,7 @@ for host in "${ALL_HOSTS[@]}"; do
with_pushd ${results_dir} \
call "${llvm_build_dir}/bin/llvm-lit" \
"${lldb_build_dir}/lit" \
${LLVM_LIT_ARGS} \
${LLVM_LIT_ARGS} -v --time-tests \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about amending LLVM_LIT_ARGS only once on line 3116?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or even earlier, since we probably want this to affect every lit invocation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

@dcci
Copy link
Member Author

dcci commented Apr 5, 2019

@swift-ci test and merge

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - 16d04c8

@dcci
Copy link
Member Author

dcci commented Apr 5, 2019 

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swiftpm/Sources/PackageDescription4/Package.swift:12:8: error: missing required module 'SwiftOverlayShims'
14:51:18 import Glibc
14:51:18        ^

is this a known issue?

@shahmishal
Copy link
Member

@dcci Yes.

/cc @Rostepher

swift-ci added a commit that referenced this pull request Apr 6, 2019
@swift-ci
Merge pull request #23781 from dcci/build-script-new
9a0d6e8
@davidungar davidungar merged commit 16d04c8 into swiftlang:master Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dcci @swift-ci @shahmishal @adrian-prantl @davidungar