build: do not search for native LLVM when not building tools #23826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @Rostepher @gottesmm |
|
@swift-ci please test |
|
Weird to me to use SWIFT_INCLUDE_TOOLS. I need to read this in more depth to understand why this is the correct thing. |
|
@gottesmm - that is because my old patch to rename the variable to what it truly is - |
Rostepher
reviewed
Apr 7, 2019
The standard library does not depend on the LLVM libraries at runtime. Do not perform the search for the LLVM configuration when the tools are not being built. This is needed to permit cross-compiling the standard library standalone for android on a Linux host without building LLVM and Clang for android.
|
@swift-ci please test |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library does not depend on the LLVM libraries at runtime. Do not
perform the search for the LLVM configuration when the tools are not being
built. This is needed to permit cross-compiling the standard library standalone
for android on a Linux host without building LLVM and Clang for android.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.