Skip to content

Move color-diagnostics to Options.td #24144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Move color-diagnostics to Options.td #24144

merged 1 commit into from
Apr 19, 2019

Conversation

keith
Copy link
Member

@keith keith commented Apr 18, 2019

This allows us to mark this flag as DoesNotAffectIncrementalBuild, so
that switching between a tty and non-tty doesn't cause full rebuilds
with swiftpm.

Resolves SR-7982.

This allows us to mark this flag as DoesNotAffectIncrementalBuild, so
that switching between a tty and non-tty doesn't cause full rebuilds
with swiftpm.

https://bugs.swift.org/browse/SR-7982
@keith
Copy link
Member Author

keith commented Apr 18, 2019

Considering this flag has limited uses we might want to mark it with HelpHidden?

@jrose-apple
Copy link
Contributor

Eh, if someone else is doing build-system-y things, they might want to know about it. Some day we might separate "esoteric but supported flags" from "flags most people care about" (as opposed to "hidden-ish and unsupported-ish flags"), but it is not this day.

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test

@jrose-apple jrose-apple self-assigned this Apr 18, 2019
@jrose-apple jrose-apple merged commit 99341a7 into swiftlang:master Apr 19, 2019
@keith keith deleted the ks/color-diagnostics branch April 19, 2019 02:41
@keith
Copy link
Member Author

keith commented Apr 19, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants