[Build System: CMake] Always copy the apinotes into the build directory when the apinotes directory is included via SWIFT_INCLUDE_APINOTES. #24527
Conversation
…ry when the apinotes directory is included via SWIFT_INCLUDE_APINOTES.
|
@swift-ci please test |
| @@ -23,7 +23,7 @@ add_custom_command( | |||
| COMMAND | |||
| "${CMAKE_COMMAND}" "-E" "copy_if_different" ${inputs} "${output_dir}/") | |||
|
|
|||
| add_custom_target("copy_apinotes" | |||
| add_custom_target("copy_apinotes" ALL | |||
| DEPENDS "${outputs}" "${output_dir}" | |||
There was a problem hiding this comment.
Question. Why are we adding add_custom_command here? Shouldn't we be using add_custom_command_target? That caused weird dependency issues for us before.
There was a problem hiding this comment.
I'm not sure about the history of this file, I didn't write this copy logic myself. We just need this target to be added to the default build target if this directory is included. This is mostly for the standalone overlay builds.
I wasn't intending to drastically change the structure for this PR as I need it to unblock some other work, but I'd be happy to discuss a more comprehensive change in the future.
There was a problem hiding this comment.
This is only adding the target, not an associated command, so this is fine as is. I had a change that replaced this with a add_custom_command_target but would lose the ability to create the symlink (and instead always copy). I think that is generally better, but, I don't know if that will create a problem for Apple's distribution.
Follow-up to #24419, we should add the
copy_apinotestarget to the default build target.