Skip to content

Add -enable-cxx-interop flag and support for extern "C" {} #24879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2019

Conversation

pschuh
Copy link
Contributor

@pschuh pschuh commented May 18, 2019

  • Updated some swift headers to build with c++ and c.
  • Added -enable-cxx-interop flag.
  • Added support for 'extern "C"'.

@pschuh pschuh requested a review from bgogul May 18, 2019 01:01
@pschuh
Copy link
Contributor Author

pschuh commented May 18, 2019

@swift-ci please test tensorflow

@harlanhaskins harlanhaskins added the tensorflow This is for "tensorflow" branch PRs. label May 20, 2019
Copy link
Contributor

@bgogul bgogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments...

- Updated some swift headers to build with c++ and c.
- Added -enable-cxx-interop flag.
- Added support for 'extern "C"'.
@pschuh
Copy link
Contributor Author

pschuh commented May 20, 2019

@swift-ci please test tensorflow

2 similar comments
@pschuh
Copy link
Contributor Author

pschuh commented May 20, 2019

@swift-ci please test tensorflow

@pschuh
Copy link
Contributor Author

pschuh commented May 20, 2019

@swift-ci please test tensorflow

@pschuh pschuh merged commit 58b3bf9 into swiftlang:tensorflow May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants