[TypeChecker] Don't try to validate generic requirements when unbound… #25181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generic types are involved If one of the generic parameters is missing let's give solver a chance to diagnose the problem, otherwise there is a risk of failing type resolution and not producing any diagnostics. Resolves: rdar://problem/50099849
|
@slavapestov I'm not certain that this is the best place to fix this problem but it's what I could come up with. |
slavapestov
approved these changes
May 31, 2019
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… generic types are involved
If one of the generic parameters is missing let's give solver a
chance to diagnose the problem, otherwise there is a risk of failing
type resolution and not producing any diagnostics.
Resolves: rdar://problem/50099849