[5.1 2019-06-12] [Type checker] Compute correct contextual substitutions for local generics #25424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teraction When the backing storage of a wrapped property is default-initialized via the property wrapper type's init(), don't count that as a direct initialization of the backing storage for the purposes of constructing the memberwise initializer. Instead, treat this case the same as if there were no initializer, keying the form of the memberwise initializer off the presence of init(initialValue:). (cherry picked from commit 5244805) (cherry picked from commit 57c69d9)
Fixes rdar://problem/51591955. (cherry picked from commit 0cc9bce)
…perValue'. Provide some backward compatibilty for property delegates written before they became property wrapper, picking up 'delegateValue' (if present) but warning about it. (cherry picked from commit 3ac7540)
(cherry picked from commit 023e449)
…erics. When applying generic arguments to a local generic type within a generic function, ensure that we correctly produce the contextual substitutions from the generic function. Fixed with Pavel, who painstakingly tracked down the bogus substitution. Fixes SR-9954 / rdar://problem/48223824. (cherry picked from commit b1503fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve compatibility of the newer property wrappers implementation with the first property-delegate-based implementation. Specifically:
@propertyWrapperas the primary attribute name; add deprecated aliases for@_propertyWrapperand@propertyDelegatedelegateValuewhenwrapperValueis not present