Small IsFinalRequest cleanup #25426
Merged
Small IsFinalRequest cleanup #25426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrappers as 'final' By calling isFinal() first in makeFinal(), we were triggering computation of IsFinalRequest and caching a value of 'false'. With lazy properties, we did direct storage access, and no accessors were synthesized anyway, but add a test for that. With property wrappers this now means the backing storage property is final, as intended (?).
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
force-pushed
the
final-request-cleanup
branch
from
bf1bd38 to
95c221a
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
apple/swift-lldb#1676 |
xymus
approved these changes
Jun 13, 2019
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding a FinalAttr directly let's have IsFinalRequest determine that lazy property and property wrapper storage is final.
This fixes a bug, apparently only on master and not swift-5.1-branch, where the property wrapper backing storage was not final.