Skip to content

[TF] Change macOS tensorflow preset from release debug info to release. #25706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

dan-zheng
Copy link
Contributor

Workaround for TF-597: IRGenDebugInfo crash.

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Jun 24, 2019
@dan-zheng
Copy link
Contributor Author

Verified that this fixes building macOS toolchains:

-- Codesign xctoolchain --
+ /Users/danielzheng/swift-toolchain/swift/utils/toolchain-codesign lldb_codesign /Users/danielzheng/swift-toolchain/swift/swift-nightly-install//Library/Developer/Toolchains/swift-tensorflow-LOCAL-2019-06-23-a.xctoolchain/
-- Create Installer --
+ /Users/danielzheng/swift-toolchain/swift/utils/toolchain-installer /Users/danielzheng/swift-toolchain/swift/swift-nightly-install//Library/Developer/Toolchains/swift-tensorflow-LOCAL-2019-06-23-a.xctoolchain/ com.google.swift.20190623 '' swift-tensorflow-LOCAL-2019-06-23-a-osx.pkg /Library/Developer/Toolchains/swift-tensorflow-LOCAL-2019-06-23-a.xctoolchain swift-tensorflow-LOCAL-2019-06-23-a /Users/danielzheng/swift-toolchain/swift/utils/darwin-installer-scripts
pkgbuild: Inferring bundle components from contents of /Users/danielzheng/swift-toolchain/swift/swift-nightly-install//Library/Developer/Toolchains/swift-tensorflow-LOCAL-2019-06-23-a.xctoolchain/
pkgbuild: Adding component at usr/lib/sourcekitd.framework/Versions/A/XPCServices/SourceKitService.xpc
pkgbuild: Adding component at System/Library/PrivateFrameworks/LLDB.framework
pkgbuild: Adding component at usr/lib/sourcekitd.framework
pkgbuild: Adding top-level postinstall script
pkgbuild: Wrote package to swift-tensorflow-LOCAL-2019-06-23-a-osx.pkg

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

Copy link

@burmako burmako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burmako burmako merged commit af0e78f into swiftlang:tensorflow Jun 24, 2019
@dan-zheng dan-zheng deleted the TF-597-workaround branch June 24, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants