Skip to content

[NFC] [AutoDiff] Gardening. #26183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dan-zheng
Copy link
Contributor

"Adjoint function" has been renamed to "pullback function".
Rename "adjoint" (as in "adjoint function") to "pullback".

The only remaining uses of "adjoint" should be "adjoint values/buffers".


Thoroughly combed through all usages of "adjoint" and "adj".

@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Jul 17, 2019
@dan-zheng dan-zheng requested review from rxwei and bartchr808 July 17, 2019 06:45
@dan-zheng dan-zheng force-pushed the rename-adjoint-to-pullback branch from 9c432fa to 95cba4b Compare July 17, 2019 06:46
"Adjoint function" has been renamed to "pullback function".
Rename "adjoint" (as in "adjoint function") to "pullback".

The only remaining uses of "adjoint" should be "adjoint values/buffers".
@dan-zheng dan-zheng force-pushed the rename-adjoint-to-pullback branch from 95cba4b to f6a6757 Compare July 17, 2019 07:05
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@bartchr808 bartchr808 merged commit 4dd0041 into swiftlang:tensorflow Jul 17, 2019
bartchr808 added a commit that referenced this pull request Jul 17, 2019
@dan-zheng dan-zheng deleted the rename-adjoint-to-pullback branch July 17, 2019 20:19
@dan-zheng dan-zheng restored the rename-adjoint-to-pullback branch July 17, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants