Fixing up IRGenModule to handle changes in CodeGenOptions. #26263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jul 22, 2019
|
Also, please don't reference the differential, but rather than the SVN revision in the commit message. |
compnerd
approved these changes
Jul 22, 2019
DisableFPElim was removed from CGO in cfe r366645. This change fixes the build for master-next.
plotfi
added a commit
to plotfi/swift
that referenced
this pull request
Jul 29, 2019
Changes I made to swift (PR swiftlang#26263) for llvm cfe r366645 have caused these tests to fail because the string attributes have changes. This patch fixes them to use the new frame pointer elision attributes.
beccadax
pushed a commit
that referenced
this pull request
Aug 21, 2019
Changes I made to swift (PR #26263) for llvm cfe r366645 have caused these tests to fail because the string attributes have changes. This patch fixes them to use the new frame pointer elision attributes. # Conflicts: # test/IRGen/generic_metatypes.swift
beccadax
pushed a commit
that referenced
this pull request
Aug 23, 2019
Changes I made to swift (PR #26263) for llvm cfe r366645 have caused these tests to fail because the string attributes have changes. This patch fixes them to use the new frame pointer elision attributes. # Conflicts: # test/IRGen/generic_metatypes.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisableFPElim was removed from CGO in https://reviews.llvm.org/D56353
This change fixes the build for master-next.