ASTPrinter: Fix generic signatures with requirements on outer parameters [5.1] #26508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We incorrectly assumed that a requirement 'rooted' in an outer parameter must be necessarily defined as part of the outer context's signature, and thus we were skipping it when printing the 'where' clause of a nested declaration or an extension of a nested type. Instead, actually get the outer generic signature and filter requirements that the outer signature satisfies. Fixes <rdar://problem/53769896>, <https://bugs.swift.org/browse/SR-11221>.
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test Linux |
|
@swift-ci Please test |
jrose-apple
reviewed
Sep 9, 2019
| // RUN: %FileCheck %s < %t/main.swiftinterface | ||
|
|
||
| // RUN: %target-build-swift %s -emit-module-interface-path %t/main.swiftinterface -enable-library-evolution -wmo | ||
| // RUN: %FileCheck %s < %t/main.swiftinterface |
There was a problem hiding this comment.
One or the other of these will always be equivalent to the frontend-only one, so you shouldn't need all three.
There was a problem hiding this comment.
I copy and pasted that from another test. I'll clean up both on master.
tkremenek
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly assumed that a requirement 'rooted' in an outer parameter
must be necessarily defined as part of the outer context's signature,
and thus we were skipping it when printing the 'where' clause of a
nested declaration or an extension of a nested type.
Instead, actually get the outer generic signature and filter requirements
that the outer signature satisfies.
Fixes rdar://problem/53769896, https://bugs.swift.org/browse/SR-11221.