Skip to content

[NFC] [AutoDiff] Gardening: @differentiable function type mangling. #26600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2019

Conversation

dan-zheng
Copy link
Contributor

  • Add todo comments tracking TF-750.
  • Optimize SWIFT_ENABLE_TENSORFLOW comments.
  • Clarify comment in test/AutoDiff/differentiable_func_debuginfo.swift.

Addresses feedback from #26595.

- Add todo comments tracking TF-750.
- Optimize `SWIFT_ENABLE_TENSORFLOW` comments.
- Clarify comment in test/AutoDiff/differentiable_func_debuginfo.swift.

Addresses feedback from swiftlang#26595.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Aug 11, 2019
@dan-zheng dan-zheng requested review from compnerd and rxwei August 11, 2019 04:02
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@compnerd
Copy link
Member

Thanks for following up on this!

@dan-zheng dan-zheng merged commit 8fc0992 into swiftlang:tensorflow Aug 11, 2019
@dan-zheng dan-zheng deleted the TF-597 branch August 11, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants