-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Constraint solver] Simplify one-way constraints to Equal, not Bind. #26700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DougGregor
merged 3 commits into
swiftlang:master
from
DougGregor:one-way-constraints-lvalues
Aug 17, 2019
Merged
[Constraint solver] Simplify one-way constraints to Equal, not Bind. #26700
DougGregor
merged 3 commits into
swiftlang:master
from
DougGregor:one-way-constraints-lvalues
Aug 17, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only care about gathering a one-way constraint if (1) the left-hand side is in the set of type variables we care about now, and (2) the type variable we started from is in the right-hand side.
There were a few places where we wanted fast testing to see whether a particular type variable is currently of interest. Instead of building local hash tables in those places, keep type variables in a SetVector for efficient testing.
One-way constraint expressions, which are the only things that introduce one-way constraints at this point, want to look through lvalue types to produce values. Rename OneWayBind to OneWayEqual, map it down to an Equal constraint when it is simplified (to drop lvalue-ness), and apply that coercion during constraint application. Part of rdar://problem/50150793.
@swift-ci please smoke test and merge |
The macOS failure looks unrelated:
|
@swift-ci please smoke test macOS |
@swift-ci please smoke test and merge |
@swift-ci please smoke test macOS |
3 similar comments
@swift-ci please smoke test macOS |
@swift-ci please smoke test macOS |
@swift-ci please smoke test macOS |
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-way constraint expressions, which are the only things that
introduce one-way constraints at this point, want to look through
lvalue types to produce values. Rename OneWayBind to OneWayEqual, map
it down to an Equal constraint when it is simplified (to drop
lvalue-ness), and apply that coercion during constraint application.
Part of rdar://problem/50150793.