Skip to content

[Diagnostics] Lift all restrictions from invalid generic arguments #26725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 19, 2019

…fix expect to optional types

This helps us to better diagnose failures related to generic
requirements like T == [Int] as well as protocol compositions,
which require deep equality check.

@xedin xedin requested a review from sl August 19, 2019 20:08
@xedin
Copy link
Contributor Author

xedin commented Aug 19, 2019

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Aug 19, 2019

@swift-ci please smoke test Linux platform

@xedin xedin force-pushed the fix-req-regressions branch from 2ce379f to 2cc8876 Compare August 20, 2019 17:06
@xedin
Copy link
Contributor Author

xedin commented Aug 20, 2019

@swift-ci please smoke test

…fix expect to optional types

This helps us to better diagnose failures related to generic
requirements like `T == [Int]` as well as protocol compositions,
which require deep equality check.
@xedin xedin force-pushed the fix-req-regressions branch from 2cc8876 to 589ebac Compare August 20, 2019 17:50
@xedin
Copy link
Contributor Author

xedin commented Aug 20, 2019

@swift-ci please smoke test

@xedin xedin merged commit 0cb7364 into swiftlang:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant