Don't crash when asking IsIUO on an incorrectly-SwiftName-d ClangImporter decl. #26726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rter decl. Sometimes the importer creates property decls with nonsensical types in response to nonsensical SwiftName attributes on Clang types. Don't crash when this happens and a property accessor happens to have an unexpected param decl.
|
@swift-ci Please smoke test |
|
Can you add a test case? |
|
I'm not sure it makes sense to, since we should really fix the Clang importer not to build nonsense ASTs like this to begin with, at which point there'd be nothing to reproduce this condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the importer creates property decls with nonsensical types in response to nonsensical
SwiftName attributes on Clang types. Don't crash in IsIUORequest when this happens and a property accessor happens to have an unexpected param decl.