[build-script] When building compiler-rt, follow LLVM's lead by speci… #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
…t before the LLVM build. When we are building LLVM create symlinks to the c++ headers. We need to do this before building LLVM since compiler-rt depends on being built with the just built clang compiler. These are normally put into place during the cmake step of LLVM's build when libcxx is in tree... but we are not building llvm with libcxx in tree when we build swift. So we need to do cmake's work here. rdar://26284108
…fying that we are using LLVM's external project mechanism. This matches the LLVM build more closely preventing potential build issues coming up. rdar://26284108
gottesmm
force-pushed
the
specify_compiler_rt_uses_llvm_external_project_mechanism
branch
from
72222c3 to
3350551
Compare
|
@swift-ci Please test |
|
The linux failure is unrelated. |
|
The linux failure is unrelated and the OS X test build compiler-rt correctly. Merging! |
gottesmm
deleted the
specify_compiler_rt_uses_llvm_external_project_mechanism
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
…fying that we are using LLVM's external project mechanism.
This matches the LLVM build more closely preventing potential build issues
coming up.
rdar://26284108