[ConstraintSystem] Introduce a fix to allow conversion between inout types
#26912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` types
If there is an argument-to-parameter conversion which is associated with
`inout` parameter, subtyping is now permitted, types have to be identical.
```swift
protocol P {}
struct S : P {}
func foo(_: inout P) {}
var s = S()
foo(&s) // `s` has to be defined as `P` e.g. `var s: P = S()`
// to be used as an argument to `inout P` parameter.
```
…ment/parameter Since there is no subtyping allowed in `inout` positions, let's produce a tailored error message and a note about that.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
This is SR-4078, yeah? |
|
@jrose-apple Yeah, that's almost it :) Let me see what else do we need to make that work, the problem is related to |
hborla
approved these changes
Aug 28, 2019
|
For posterity, example in SR-4078 is not handled by this fix because types |
|
This also removes last special case from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an argument-to-parameter conversion which is associated with
inoutparameter, subtyping is now permitted, types have to be identical.